Skip to content

Conversation

@puhtaytow
Copy link

@puhtaytow puhtaytow commented Nov 14, 2025

Problem

Frozen ABI does not actually check ABI and checks API compatibility instead

Agave#8091
example of use

Summary of Changes

Frozen ABI now supports both API compatibility checks and ABI stability checks.

  • Introduced the new StableAbi trait.
  • Updated macros to generate API and ABI tests conditionally.
  • Added a test_abi_ test that compares the provided abi_digest with a deterministically computed digest based on hashing multiple randomized instances of the tested type.

@puhtaytow puhtaytow marked this pull request as draft November 14, 2025 18:40
@puhtaytow puhtaytow force-pushed the frozen-abi-add-stable-abi-trait branch 7 times, most recently from bcc5c14 to 9c3257a Compare November 18, 2025 14:27
@puhtaytow puhtaytow changed the title introduce StableAbi extension to frozen-abi Add StableAbi extension to frozen-abi Nov 18, 2025
@puhtaytow puhtaytow force-pushed the frozen-abi-add-stable-abi-trait branch from 9c3257a to e6ffecf Compare November 18, 2025 14:29
@puhtaytow puhtaytow force-pushed the frozen-abi-add-stable-abi-trait branch 4 times, most recently from 10cebed to 1513a4c Compare November 18, 2025 14:47
@puhtaytow puhtaytow changed the title Add StableAbi extension to frozen-abi Add StableAbi extension to frozen-abi / agave#8091 Nov 18, 2025
@puhtaytow puhtaytow force-pushed the frozen-abi-add-stable-abi-trait branch from 1513a4c to f675262 Compare November 18, 2025 15:05
@puhtaytow puhtaytow marked this pull request as ready for review November 18, 2025 15:07
@puhtaytow puhtaytow force-pushed the frozen-abi-add-stable-abi-trait branch from f675262 to 69d4017 Compare November 18, 2025 15:22
@alexpyattaev alexpyattaev changed the title Add StableAbi extension to frozen-abi / agave#8091 frozen-abi: check actual ABI compatibility ( agave issue #8091 ) Nov 18, 2025
@puhtaytow puhtaytow force-pushed the frozen-abi-add-stable-abi-trait branch 3 times, most recently from cd5faad to 82b47bf Compare November 19, 2025 15:15
@puhtaytow puhtaytow force-pushed the frozen-abi-add-stable-abi-trait branch from 82b47bf to 1099f6f Compare November 19, 2025 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant